-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional ean13 country exception. #128
Optional ean13 country exception. #128
Conversation
Can I get a description of why this is needed? |
|
Hi,
I have a customer that uses EAN-13 for their internal use too. They encode
article number and size code (for clothes) in it. A bit crazy.
/rob
…On Sun, May 9, 2021, 09:39 Sergey Tkachenko ***@***.***> wrote:
Can I get a description of why this is needed?
Hi, Brad. Our company uses EAN13 for internal tasks, inside our country.
Because of it, the country code is not used. We use the whole number as ID.
And some numbers cause "invalid country code" exceptions. But managers say
these numbers are necessary. So, without these changes, we can't use nuget
package of BarcodeLib to replace our own legacy code.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#128 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFQNI4OANGQKIYNANT73QUTTMY34FANCNFSM44FECHGA>
.
|
@rob313663 and @CanSeeThePain, I just released 2.4.0 to NuGet. It might take a little bit to show up but its on its way. The feature you added I modified slightly to allow for disabling of country code parsing and not just throwing the exception away. This will allow for slightly better efficient generation of EAN-13 codes. Same general concept but just took it a step further. I have also allowed for retrieval of the country code via a property since that was overlooked originally. Thanks for the submission and keep the updates coming! Keep me posted on how you are using it just for my curiosity! |
Thank you very much! My team leader will be happy to get these changes in the NuGet package :) |
After loading 2.4.0 and adding it to my project, I tried to reproduce the country exception, but to no avail. It seems that now, because all country codes between 0 and 100 filled, at least 2-digits country code will always present. So I think that exception now is unreachable. |
No description provided.