Remove credentials parsing and let the SDK handle it #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnybug
requested changes
Jan 11, 2018
| } | ||
| profile := c.String("profile") | ||
| if profile != "" { | ||
| sess := session.Must(session.NewSessionWithOptions(session.Options{ |
There was a problem hiding this comment.
session.Must isn't right here - it forces a panic on error. getService should return the error so it can be presented to the user in a friendly manner.
| })) | ||
| return route53.New(sess), nil | ||
| } else { | ||
| sess := session.Must(session.NewSessionWithOptions(session.Options{ |
There was a problem hiding this comment.
This whole block of code is duplicated in both branches of the condition - when in fact it should just set .Profile on session.Options when profile != ""
| } | ||
| return route53.New(session.New(), config), nil | ||
| } | ||
| profile := c.String("profile") |
There was a problem hiding this comment.
Indentation needs fixing on the code - please run gofmt
|
Thanks for the cleanup! (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a simple PR to let the SDK do the work of finding a profile/credentials.