Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare usernames case insensitively #75

Open
alexcrichton opened this issue Mar 23, 2015 · 0 comments
Open

Compare usernames case insensitively #75

alexcrichton opened this issue Mar 23, 2015 · 0 comments

Comments

@alexcrichton
Copy link
Contributor

I added the all-lowercase version of a username to cfg.toml, but it failed to recognize them as a reviewer because their username had a different case definition. Would it be possible for homu to test usernames case insensitively for equality? I believe github already does so as well.
Manishearth pushed a commit to Manishearth/homu that referenced this issue Mar 14, 2017
Auto merge of barosl#75 - cgwalters:subprocess-stderr, r=Manishearth
288757f 
utils: Print stderr from child processes by default

If for example `git fetch` fails due to a permission error, the github.com ssh
key changing, a segfault inside one of the helper binaries or whatever - I
really want to see that by default.

Currently when running in Kubernetes/Docker I see a Python stack trace, but not
the actual error.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/75)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexcrichton