Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homu chooses the wrong commit #99

Closed
Ryman opened this issue Aug 29, 2015 · 1 comment
Closed

Homu chooses the wrong commit #99

Ryman opened this issue Aug 29, 2015 · 1 comment

Comments

@Ryman
Copy link

Ryman commented Aug 29, 2015

E.g. nickel-org/nickel.rs#267 (comment)

Homu is choosing a non-existing commit (which looks a lot like a null value somewhere) of 0000000 and nothing seems to happen. On the queue it is still listed as approved.

There has been squashing and rebasing on the branch, if that's of any concern?
@Ryman
Copy link
Author

Ryman commented Sep 7, 2015

This was fixed :)

@Ryman Ryman closed this as completed Sep 7, 2015
barosl added a commit that referenced this issue Oct 15, 2015
@barosl
Retrieve head SHA manually if it is invalid
7a35fde 
Sometimes, GitHub sends the head SHA of a PR as 0000000 through the
webhook. This is called a "null commit", and seems to happen when GitHub
internally encounters a race condition. Last time, it happened when
squashing commits in a PR. In this case, we just try to retrieve the
head SHA manually.

Fixes #99.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ryman