Fixed imports and add tests

barracksiot · Jul 21, 2017 · 2a9f769 · 2a9f769
1 parent 69de8e0
commit 2a9f769
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 2 deletions.
diff --git a/src/clients/HookClient.js b/src/clients/HookClient.js
@@ -1,6 +1,4 @@
-const PageableStream = require('./PageableStream');
 const HTTPClient = require('./HTTPClient');
-const logger = require('../utils/logger');
 
 const endpoints = {
   createHook: {

diff --git a/tests/clients/HookClient.spec.js b/tests/clients/HookClient.spec.js
@@ -53,6 +53,32 @@ describe('hookClient', () => {
       });
     });
 
+    it('should return an error message when request fails with statusCode 400', done => {
+      // Given
+      const hook = { type: 'web', name: 'Hook', url: 'https://localhost/hookName' };
+      const error = { message: 'Error !', statusCode: 400 };
+      hookClient.httpClient.sendEndpointRequest = sinon.stub().returns(Promise.reject(error));
+
+      // When / Then
+      hookClient.createHook(token, hook).then(result => {
+        done('should have failed');
+      }).catch(err => {
+        expect(err).to.be.equals('A hook with this name already exists.');
+        expect(hookClient.httpClient.sendEndpointRequest).to.have.been.calledOnce;
+        expect(hookClient.httpClient.sendEndpointRequest).to.have.been.calledWithExactly(
+          {
+            method: 'POST',
+            path: '/api/dispatcher/hooks'
+          },
+          {
+            headers: { 'x-auth-token': token },
+            body: hook
+          }
+        );
+        done();
+      });
+    });
+
     it('should return the created hook', done => {
       // Given
       const hook = { type: 'web', name: 'Hook', url: 'https://localhost/hookName' };
@@ -109,6 +135,32 @@ describe('hookClient', () => {
       });
     });
 
+    it('should return an error message when request fails with a 404', done => {
+      // Given
+      const name = 'aHook';
+      const error = { message: 'Error !', statusCode: 404 };
+      hookClient.httpClient.sendEndpointRequest = sinon.stub().returns(Promise.reject(error));
+
+      // When / Then
+      hookClient.deleteHook(token, name).then(result => {
+        done('should have failed');
+      }).catch(err => {
+        expect(err).to.be.equals('The hook you are trying to remove does not exist.');
+        expect(hookClient.httpClient.sendEndpointRequest).to.have.been.calledOnce;
+        expect(hookClient.httpClient.sendEndpointRequest).to.have.been.calledWithExactly(
+          {
+            method: 'DELETE',
+            path: '/api/dispatcher/hooks/:hook'
+          },
+          {
+            headers: { 'x-auth-token': token },
+            pathVariables: { hook: name }
+          }
+        );
+        done();
+      });
+    });
+
     it('should return nothing when hook is deleted', done => {
       // Given
       const name = 'aHook';