Bo 1575 : Add hook triggered when there is a change in packages #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
remiriv
commented
Aug 9, 2017
•
remiriv
commented
weber-gregoire
requested changes
Aug 11, 2017
| @@ -3,53 +3,56 @@ const Validator = require('../../utils/Validator'); | |||
| const ObjectReader = require('../../utils/ObjectReader'); | |||
|
|
|||
| function getHookType(program) { | |||
| if (program.web) { | |||
| if (program.hookType === 'web') { | |||
There was a problem hiding this comment.
extract logic and remove if/elseif
| return 'bigquery'; | ||
| } | ||
| } | ||
|
|
||
| function getEventType(program) { | ||
| if (program.ping) { | ||
| if (program.event === 'ping') { |
There was a problem hiding this comment.
extract logic and remove if/elseif
| !program.web && program.googleAnalytics && !program.bigquery && program.gaTrackingId && program.gaTrackingId !== true || | ||
| !program.web && !program.googleAnalytics && program.bigquery && program.googleClientSecret && Validator.fileExists(program.googleClientSecret)); | ||
|
|
||
| var handlers = { |
There was a problem hiding this comment.
const, and extract it to be global and private
| bigQuery: (program) => program.googleClientSecret && program.googleClientSecret !== true && Validator.fileExists(program.googleClientSecret) | ||
| } | ||
|
|
||
| return (['web', 'googleAnalytics', 'bigQuery'].indexOf(program.hookType) > -1) && handlers[program.hookType](program) |
There was a problem hiding this comment.
use handlers to do the validation instead of an hardcoded array
weber-gregoire
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.