Update check update to match new format returned by barracks

barracksiot · Mar 24, 2017 · 87bdc28 · 87bdc28
1 parent f6dc117
commit 87bdc28
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 227 deletions.
diff --git a/example/index.js b/example/index.js
@@ -33,7 +33,7 @@ var barracks = new Barracks({
   downloadFilePath: '/tmp/file.tmp'
 });
 
-fucntion donwloadPackages(packages) {
+function donwloadPackages(packages) {
   var promises = packages.map(function (package) {
     return package.download('/tmp/' + package.package + '_' + package.version + '_' + package.filename);
   });

diff --git a/src/clientHelper.js b/src/clientHelper.js
diff --git a/src/index.js b/src/index.js
@@ -10,7 +10,6 @@ var CHECK_UPDATE_ENDPOINT       = '/api/device/v2/update/check';
 require('es6-promise').polyfill();
 var fs = require('fs');
 var request = require('request');
-var clientHelper = require('./clientHelper');
 var fileHelper = require('./fileHelper');
 
 function Barracks(options) {
@@ -50,7 +49,7 @@ Barracks.prototype.checkUpdate = function (packages, customClientData) {
           message: 'Check Update request failed: ' + error.message
         });
       } else if (response.statusCode == 200) {
-        resolve(clientHelper.buildCheckUpdateResult(JSON.parse(body), that));
+        resolve(JSON.parse(body));
       } else {
         reject({
           type: ERROR_UNEXPECTED_SERVER_RESPONSE,

diff --git a/tests/clientHelper_test.js b/tests/clientHelper_test.js
diff --git a/tests/index_test.js b/tests/index_test.js
@@ -108,7 +108,6 @@ describe('checkUpdate(components, customClientData) ', function () {
 
   var barracks;
   var requestMock = function () {};
-  var buildCheckUpdateResultMock = function () {};
 
   function getRequestPayloadForComponents(components) {
     return {
@@ -130,11 +129,6 @@ describe('checkUpdate(components, customClientData) ', function () {
     var Barracks = proxyquire('../src/index.js', {
       'request': function (options, callback) {
         return requestMock(options, callback);
-      },
-      './clientHelper': {
-        buildCheckUpdateResult: function (response) {
-          return buildCheckUpdateResultMock(response);
-        }
       }
     });
 
@@ -217,11 +211,6 @@ describe('checkUpdate(components, customClientData) ', function () {
       requestSpy(options, callback);
       callback(undefined, response, response.body);
     };
-    var buildCheckUpdateResultSpy = sinon.spy();
-    buildCheckUpdateResultMock = function (response) {
-      buildCheckUpdateResultSpy(response);
-      return response;
-    };
 
     // When / Then
     barracks.checkUpdate(components).then(function (result) {
@@ -231,8 +220,6 @@ describe('checkUpdate(components, customClientData) ', function () {
         getRequestPayloadForComponents(components),
         sinon.match.func
       );
-      expect(buildCheckUpdateResultSpy).to.have.been.calledOnce;
-      expect(buildCheckUpdateResultSpy).to.have.been.calledWithExactly(componentInfo);
       done();
     }).catch(function (err) {
       done(err);
@@ -257,11 +244,6 @@ describe('checkUpdate(components, customClientData) ', function () {
       requestSpy(options, callback);
       callback(undefined, response, response.body);
     };
-    var buildCheckUpdateResultSpy = sinon.spy();
-    buildCheckUpdateResultMock = function (response) {
-      buildCheckUpdateResultSpy(response);
-      return response;
-    };
 
     // When / Then
     barracks.checkUpdate(components).then(function (result) {
@@ -271,8 +253,6 @@ describe('checkUpdate(components, customClientData) ', function () {
         getRequestPayloadForComponents(components),
         sinon.match.func
       );
-      expect(buildCheckUpdateResultSpy).to.have.been.calledOnce;
-      expect(buildCheckUpdateResultSpy).to.have.been.calledWithExactly(componentInfo);
       done();
     }).catch(function (err) {
       done(err);