Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider making pyobd PEP517 compliant by adding pyproject.toml, etc, and placing it on https://pypi.org ? #5

Open
yurivict opened this issue Sep 16, 2023 · 7 comments · May be fixed by #7

Comments

@yurivict
Copy link

yurivict commented Sep 16, 2023

This should install the executable "pyobd" into bin/.

This would make it easy to create ports/packages for it, and this would make it easier to install for users.

Thanks,
Yuri

@Kydlaw
Copy link

Kydlaw commented Sep 17, 2023

Maybe barracuda-fsh doesn't want to create a lib out of this code.

But that would be interesting to define at least the minimum version of Python required in this project.

@yurivict
Copy link
Author

Maybe barracuda-fsh doesn't want to create a lib out of this code.

It's not about making it into a lib.
PEP517 allows to install executables in a uniform way which makes it easy to install using standard methods.

Kydlaw added a commit to Kydlaw/pyobd that referenced this issue Sep 19, 2023
@Kydlaw Kydlaw linked a pull request Sep 19, 2023 that will close this issue
@gray-adeyi
Copy link

The name pyobd and obd is already taken on pypi

@yurivict
Copy link
Author

@gray-adeyi

Just name it pyobd2 or obd2 then.
Many other projects solve this problem this way.

@gray-adeyi
Copy link

gray-adeyi commented Sep 26, 2023

Okay great! I'll be working on it . Pyobd2 it is

@chrisdebian
Copy link

chrisdebian commented Sep 26, 2023 via email

@Kydlaw
Copy link

Kydlaw commented Sep 26, 2023

I updated the PR to use pyobd2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants