Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Killed ThreadAction is unused #198

Closed
barrucadu opened this issue Feb 13, 2018 · 0 comments · Fixed by #251
Closed

Killed ThreadAction is unused #198

barrucadu opened this issue Feb 13, 2018 · 0 comments · Fixed by #251
Labels
breaking good first issue T: enhancement

Comments

@barrucadu
Copy link
Owner

dejafu/dejafu/Test/DejaFu/Types.hs

Lines 159 to 160 in be66679

| Killed
-- ^ Killed by an uncaught exception.

These aren't created (and haven't been for a while), the constructor should just be removed. This'll simplify the logic and tests around rewinding.
barrucadu added a commit that referenced this issue Mar 10, 2018
@barrucadu
Remove 'Killed' thread action
5c419ac 
Closes #198
barrucadu added a commit that referenced this issue Mar 10, 2018
@barrucadu
Remove 'Killed' thread action
6d6331d 
Closes #198
barrucadu added a commit that referenced this issue Mar 10, 2018
@barrucadu
Remove 'Killed' thread action
89d1f93 
Closes #198
barrucadu added a commit that referenced this issue Mar 17, 2018
@barrucadu
Remove 'Killed'
d7c1191 
Closes #198
@barrucadu barrucadu mentioned this issue Mar 17, 2018
Merged
barrucadu added a commit that referenced this issue Mar 17, 2018
@barrucadu
Remove 'Killed'
d51d150 
Closes #198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking good first issue T: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring barrucadu/dejafu
1 participant
@barrucadu