Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI issues #300

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Fix CI issues #300

merged 4 commits into from
Oct 4, 2019

Conversation

barrucadu
Copy link
Owner

Summary

There's been some CI bit-rot:

  • Latest stack doesn't support all the older LTSes I use, so the version needs pinning
  • Unused import warnings have cropped up, but I remember making a conscious decision in the past not to use CPP to suppress those (too much cognitive overhead thinking "why is this CPP here?")
  • Weeder seems to have broken, or changed how it's supposed to be invoked, but I can't see how to fix it
  • Hlint has more lints

As this only affects CI scripts, no new releases are needed.

@barrucadu
Pin stack version in CI
5553643
@barrucadu
Don't warn on unused imports in CI
47dc671 
Different imports are needed by different library versions.  Adding
CPP to conditionally remove an include is over-complicating matters.
@barrucadu
Disable weeder in CI linting
420d1f0 
It's reporting that every module is unused, which isn't true.  The
weeder README says this is still the correct way to do things, so I'm
not sure what's going on.
@barrucadu
Add lints for law tests
290aef7
@barrucadu barrucadu merged commit eed31f9 into master Oct 4, 2019
@barrucadu barrucadu deleted the ci-fixes branch October 4, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@barrucadu