Sequential handlers and managed threads #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client now has a collection of threads which it kills on disconnect, these can be created by the programmer as an `IRC` action from (for example) event handlers, to manage long-running tasks.
|
Finally found some time to check out your proposal. Sorry for the delay and thanks for maintaining and improving your library! I really like your approach to managing threads and will very likely use it in my little utility to fork a thread for handling the actual DCC file transfer once released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly large conceptual change, so I'm putting it up for some review before I merge it. This PR has two changes:
EventHandlers are now executed sequentially, in the order they appear in thehandlerslist. So:"Managed" threads are introduced, which are threads which will be killed by the client (by throwing the new
Disconnectexception) when it disconnects.Currently killing the managed threads is not part of the on-disconnect handler, it's done in the
disconnectfunction. This could be changed if people feel that would be better.CC @liyang @JanGe (by the way, let me know if you don't want me to ping you like this, but you're the only users I know for certain I have, other than myself)