Only return ServFail if answers & authority are empty
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two cases when the answers can be empty: - `NXDOMAIN` - the server is authoritative for this zone and the domain does not exist. - `NODATA` - the server is authoritative for this zone, the domain exists, but there's no record of the requested type. This commit fixes this case. In both of these cases, the SOA record should be returned in the authority section. So, change the `ServFail` case to only return an error if there are no authority records, as that could indicate a failure talking to upstream nameservers. Additionally, `NODATA` should be returned if the server is non-authoritative for this domain and the authoritative server returns `NXDOMAIN` or `NODATA`. Changes will be required to the recursive and forwarding resolvers (to pass along the relevant SOA record) to support this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two cases when the answers can be empty:
NXDOMAIN- the server is authoritative for this zone and the domain does not exist.NODATA- the server is authoritative for this zone, the domain exists, but there's no record of the requested type. This commit fixes this case.In both of these cases, the SOA record should be returned in the authority section. So, change the
ServFailcase to only return an error if there are no authority records, as that could indicate a failure talking to upstream nameservers.Additionally,
NODATAshould be returned if the server is non-authoritative for this domain and the authoritative server returnsNXDOMAINorNODATA. Changes will be required to the recursive and forwarding resolvers (to pass along the relevant SOA record) to support this case