Make default api_url language specific #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this you have to pass both `url` and `lang` to get a non-English Wikipedia to work.
dan-blanchard
changed the title
lang to MediaWiki.__init__ work
|
@dan-blanchard This pull request looks good! I will definitely merge it in! Thanks! |
|
It will take awhile for me to get this change onto pypi, but it should be done by the end of the week. Also, if you don't mind, I will add you to the contributors list. Thanks again for helping out and I hope you are enjoying the library! |
|
The end of the week is plenty fast for me. I'm one of the maintainers of chardet and I've been trying to finish up a release there for over a year, so a few days is nothing. 😄 |
|
Dan, this has been pushed to PyPi as part of the 0.3.12 version. Thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this you have to pass both
urlandlangto get a non-English Wikipedia to work.