Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:calculation of elements_added on join #119

Merged
merged 2 commits into from Jan 25, 2024
Merged

Conversation

cunla
Copy link
Contributor

@cunla cunla commented Jan 25, 2024

Thanks for this library! It is very helpful.
I found a small bug in the CMS.join() - here is a fix and a test.

@barrust
Copy link
Owner

barrust commented Jan 25, 2024

Great catch! The current failures are a codecov upload problem on their end.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6feb143) 99.61% compared to head (c94820b) 99.61%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          16       16           
  Lines        1801     1801           
=======================================
  Hits         1794     1794           
  Misses          7        7           
Files Coverage Δ
probables/countminsketch/countminsketch.py 100.00% <100.00%> (ø)

@barrust barrust merged commit 505777b into barrust:master Jan 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants