Improved format parsing and serializing for cuckoo filter #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KOLANICH
force-pushed
the
parse
branch
10 times, most recently
from
43f021a
to
e94e5e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
- Coverage 99.08% 98.46% -0.63%
==========================================
Files 15 15
Lines 1419 1495 +76
==========================================
+ Hits 1406 1472 +66
- Misses 13 23 +10
|
KOLANICH
changed the title
|
This looks good in a cursory look but I will need to spend more time to actually review it.
Thanks! |
KOLANICH
force-pushed
the
parse
branch
3 times, most recently
from
6930830
to
7ff9326
Compare
1. Used typed arrays for better efficiency. 2. Utilized memory maps for parsing. 3. Allow parsing and serializing from/to `ByteString`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.