Look everything over and figure out what I changed

[barrykn]

(NOTE: This is my first time filing a bug against my own project. This isn't really a bug report or even a general issue as much as a bunch of stuff I need to put into writing, so expect rambling and incoherence here. Sorry.)

So many small but vitally important changes over so many different repos... I need to look over it all and list all of my hacks in one place, so I have a relatively concise overview. (I should have been filing bugs against my own project all along, but at least I'm starting to do that now.)

Also, I need to figure out what I need to get changed (more cleanly of course) upstream (either CyanogenMod or AOSP). That's sufficiently related to this list that I guess I'll stuff it into this bug.

2waysup volume button hack: Almost certainly nothing here that should go upstream.

Contacts app hacking: Right now I think this is incomplete, I'll revisit the question after this stabilizes more.

3 things in android_frameworks_base:

1. Global Actions dialog (over)simplification: I think there are enhancements in CM10.0 that effectively implement this the right way. Looking at that in more detail will have to wait for later, though.
2. 1500ms long press timeout. This was actually inspired by Android 4.0, so nothing here is suitable for upstream. (Unless I want to do a proper backport of the Android 4.0 long press preference and submit it for a future CyanogenMod 7 release, but that's a low priority right now.)
3. 1500ms long press timeout on Global Actions (Power) key: I dearly want to see a pref for this in a future Android release. I'll look into filing a feature request (or whatever) for AOSP (and at that time I'll explain why this is necessary).

Finally, regarding changing the default baseband (this is a Defy-specific quirk, essentially): What I've been doing instead is to initially skip installation of the Google apps, change the baseband and/or set up WiFi, then install the Google apps, log in, etc.

[barrykn]

In barrykn/android_packages_apps_Contacts-cm-bkndh1 (Contacts app hacking):

1. I removed the Favorites tab (no issue assigned, oops).
2. I removed the ability to mark contacts as Favorites (Eliminate the ability to mark a contact as a favorite android_packages_apps_Contacts-cm-bkndh1#2).
3. I removed the SMS button in the contact detail view (In contact detail view, eliminate texting button on phone numbers android_packages_apps_Contacts-cm-bkndh1#1).

This set of changes has proven to be a huge improvement (for my user).

At this point I don't see myself making any more Contacts app changes for CM7.x. My current thinking is that anything I could accomplish with more changes here, would be accomplished more effectively by forward-porting my changes to CM10.x so I can move my user to newer & better hardware. I need to see which of these changes apply to CM10.x; that might become a new issue (maybe even on a new GitHub project).

[barrykn]

Regarding the Global Actions dialog box: CM9.1 doesn't have any modifications here, but CM10.0 and 10.1 are perfect. (FWIW they call it the "power menu".) Not that I expect to do this, but if for some reason I end up needing to use CM9.x as a base, I could hack the power menu myself, as I do on CM7.2. (Or I could hope that the 1500ms power button long-press timeout, alone, is sufficient.)

I should see how Contacts in CM10.1 compares to CM7.2, to see which of my changes I need to port forward.

(At this point I'm starting to clutter this issue, but it's my own project so I can do that ^_~ and it's more important that I get this stuff down in writing.)

[barrykn]

Hmm, both Phone and (especially) Contacts/People changed massively from Gingerbread to Jelly Bean. The idea of not changing anything in Phone or People (in Jelly Bean) is tempting. I have a dreadful feeling that it'll fail, but it's tempting.

[barrykn]

And just when I thought my changes to Contacts (in CM7.2) had stabilized, I saw a new problem today: barrykn/android_packages_apps_Contacts-cm-bkndh1#3 sigh

(Basically, Quick Contact Badges are bad for my user -- she pulls up quick contact badge menus by accident and ends up calling the wrong people at inopportune times of day. With the menus disabled, nothing will happen, which should give her an opportunity to tap again in the correct location.)

[barrykn]

I forgot to mention that I changed the Defy's charge-only mode to automatically reboot once the voltage is high enough (issue 2).

[barrykn]

(Edited 2013-08-25.)

Current status of this project:

My main user has passed away, however there are a few other users (for now anyway). So, the project isn't completely dead. However, without this project's primary user, the impetus for new features is basically gone. Thus, the CM7.2 branch is now in feature freeze. I might fix security issues for some indefinite period of time, and I might revert the fix for issue #8 (which made the long-press timeout really long) if that turns out to be necessary for the remaining users. Otherwise, the project's (nearly) done.

I still need to publish the rest of my CM10.x patches (this is holding issue #7 open), and I need to properly document my changes versus CM7.2 (issue #12) and CM10.x (issue #13). I will almost certainly do more testing of my CM10.1 branch and could make changes as a result, so that branch is not yet in feature freeze.

Unlike my primary user, my remaining users could switch over to stock iPhone/iOS, or (probably) stock Android 4.x, and not have any trouble. So, I could theoretically just bring the project to a complete close right now. However, the CM7.2 branch is still useful as long as my remaining users are still on CM7.2 -- I don't need to force the issue right this second -- and the CM10.1 branch is so close to completion that it would be a true shame not to finish it.

As of this writing, I have not publicized this project anywhere on the Internet, so I don't expect that anyone else is aware of and benefiting from this project. However, if that changes, I can certainly change course and continue to maintain this project rather than winding it down.