-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1500ms long press delay is too short!! #8
Comments
Memo to self: RESIST THE TEMPTATION TO SLAM A FIX FOR THIS INTO PRODUCTION. THIS NEEDS TESTING FIRST. |
Quoting from barrykn/android_frameworks_base-cm72-bkndh1@0e201a5: "My gut feeling is that 1500ms won't be enough, but I think I'll give sanity a chance first." Heh. I sure didn't expect it to take almost a year for my gut instinct to be validated, however. |
Oops, I wasn't expecting "should fix" to automatically close this issue -- I still need to fix it for CM10.1. |
I've coded a fix for CM10.1 but I have some more issues to file (and code fixes for) before I test. |
15 seconds was too insane. I think this might have just the perfect amount of insanity. (^_^) Related to barrykn/android-cm7-bkndh1#8.
I've tested the fix for both CM7.2 and CM10.1, but I'll leave this issue open until I get the CM10.1 code posted to GitHub. |
By the way, 14.5 seconds is working fine in production on CM7.2. So far. |
For the record: By the time this change became necessary, my user was much closer to the end of her life than I [had] realized [at the time]. [Edited 20130813 -- attempted to clarify this comment.] |
In retrospect, perhaps 5 seconds would have been sufficient. However, I couldn't have been absolutely sure, and I didn't want to take any chances. However, I do want to note that down in case I (or anyone) need(s) to revisit this issue at any point. |
I just got to see this today. I don't know how long will be long enough. :(
The text was updated successfully, but these errors were encountered: