Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1500ms long press delay is too short!! #8

Open
barrykn opened this issue May 31, 2013 · 8 comments
Open

1500ms long press delay is too short!! #8

barrykn opened this issue May 31, 2013 · 8 comments
Assignees

Comments

@barrykn
Copy link
Owner

barrykn commented May 31, 2013

I just got to see this today. I don't know how long will be long enough. :(

@ghost ghost assigned barrykn May 31, 2013
@barrykn
Copy link
Owner Author

barrykn commented May 31, 2013

Memo to self: RESIST THE TEMPTATION TO SLAM A FIX FOR THIS INTO PRODUCTION. THIS NEEDS TESTING FIRST.

@barrykn
Copy link
Owner Author

barrykn commented May 31, 2013

Quoting from barrykn/android_frameworks_base-cm72-bkndh1@0e201a5:

"My gut feeling is that 1500ms won't be enough, but I think I'll give sanity a chance first."

Heh. I sure didn't expect it to take almost a year for my gut instinct to be validated, however.

@barrykn
Copy link
Owner Author

barrykn commented Jun 2, 2013

Oops, I wasn't expecting "should fix" to automatically close this issue -- I still need to fix it for CM10.1.

@barrykn barrykn reopened this Jun 2, 2013
@barrykn
Copy link
Owner Author

barrykn commented Jun 2, 2013

I've coded a fix for CM10.1 but I have some more issues to file (and code fixes for) before I test.

barrykn added a commit to barrykn/android_frameworks_base-cm72-bkndh1 that referenced this issue Jun 2, 2013
15 seconds was too insane. I think this might have just the perfect
amount of insanity. (^_^)

Related to barrykn/android-cm7-bkndh1#8.
@barrykn
Copy link
Owner Author

barrykn commented Jun 2, 2013

I've tested the fix for both CM7.2 and CM10.1, but I'll leave this issue open until I get the CM10.1 code posted to GitHub.

@barrykn
Copy link
Owner Author

barrykn commented Jul 8, 2013

By the way, 14.5 seconds is working fine in production on CM7.2. So far.

@barrykn
Copy link
Owner Author

barrykn commented Jul 16, 2013

For the record: By the time this change became necessary, my user was much closer to the end of her life than I [had] realized [at the time]. [Edited 20130813 -- attempted to clarify this comment.]

@barrykn
Copy link
Owner Author

barrykn commented Aug 19, 2013

In retrospect, perhaps 5 seconds would have been sufficient. However, I couldn't have been absolutely sure, and I didn't want to take any chances.

However, I do want to note that down in case I (or anyone) need(s) to revisit this issue at any point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant