Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify call detail #9

Closed
barrykn opened this issue Jun 2, 2013 · 2 comments
Closed

Simplify call detail #9

barrykn opened this issue Jun 2, 2013 · 2 comments
Assignees
@barrykn

Comments

@barrykn
Copy link
Owner

barrykn commented Jun 2, 2013

In the call log, tapping a call (to bring up call detail) shows options for adding a new contact and for sending SMS. I may need to remove the new contact button. I absolutely need to remove the SMS button.

This affects both CM7.2 and 10.1.
@ghost ghost assigned barrykn Jun 2, 2013
@barrykn
Copy link
Owner Author

barrykn commented Jun 2, 2013

Reopening (again, fixed for CM7.2 but not yet for CM10.1; also, not tested yet).

@barrykn barrykn reopened this Jun 2, 2013
barrykn added a commit to barrykn/android_packages_apps_Contacts-cm-bkndh1 that referenced this issue Jun 2, 2013
@barrykn
PhoneNumberHelper.java: Disable SMS
92f9e0d 
Part of fixing barrykn/android-cm7-bkndh1#9.
barrykn added a commit to barrykn/android_packages_apps_Contacts-cm-bkndh1 that referenced this issue Jun 2, 2013
@barrykn
CallDetailHeader: Don't offer to add a number to contacts.
f393e5a 
This is related to barrykn/android-cm7-bkndh1#9.
barrykn added a commit to barrykn/android_packages_apps_Contacts-cm-bkndh1 that referenced this issue Jun 2, 2013
@barrykn
CallDetailActivity: Remove add-or-edit option too
9fa69c2 
Related to barrykn/android-cm7-bkndh1#9.
@barrykn
Copy link
Owner Author

barrykn commented Jun 2, 2013

On one level, it kind of scares me that I've left the blacklisting option intact. However, I need to consider that (a) it's buried in a menu, (b) my user hasn't triggered it by accident (AFAIK), (c) on both CM7 & CM10 I can check whether any numbers have been placed on it (I'll do that the next time I see my user), and (d) it's something I need to leave available for future possibilities.

So, I think that means I've finished simplifying the call detail view on both CM7 & CM10 (including coding & testing). Thus, it's time to close this issue.

@barrykn barrykn closed this as completed Jun 2, 2013
barrykn added a commit to barrykn/android_packages_apps_Contacts-cm-bkndh1 that referenced this issue Jun 4, 2013
@barrykn
PhoneNumberHelper.java: Disable SMS
f5ebda3 
Part of fixing barrykn/android-cm7-bkndh1#9.
barrykn added a commit to barrykn/android_packages_apps_Contacts-cm-bkndh1 that referenced this issue Jun 5, 2013
@barrykn
CallDetailActivity: Don't offer to add a number to contacts.
d92a767 
This is related to barrykn/android-cm7-bkndh1#9, and it's a
manual backport of:

commit f393e5a
Author: Barry K. Nathan <barryn@pobox.com>
Date:   Sun Jun 2 08:45:21 2013 -0700

    CallDetailHeader: Don't offer to add a number to contacts.

    This is related to barrykn/android-cm7-bkndh1#9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barrykn barrykn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barrykn