Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.4 changes that break the debugbar #582

Closed
martindilling opened this issue Jan 5, 2017 · 3 comments
Closed

Laravel 5.4 changes that break the debugbar #582

martindilling opened this issue Jan 5, 2017 · 3 comments
Labels

Comments

@martindilling
Copy link
Contributor

I stumbled into a few issues trying to get this working with the 5.4-dev (I know it's not released yet, but if I don't write them now, I wouldn't write them xD).
I don't really have time to work on a PR, but hopefully this can at least help find the right places to look :)


This commit broke the log listener:
laravel/framework@57c82d0?diff=split
What I could figure out was that this needs to accept the new MessageLogged class instead of the separate values:
https://github.com/barryvdh/laravel-debugbar/blob/master/src/LaravelDebugbar.php#L234


This commit broke the session collector:
laravel/framework@66976ba?diff=split
I see the interface/class is typehinted here:
https://github.com/barryvdh/laravel-debugbar/blob/master/src/DataCollector/SessionCollector.php
https://github.com/barryvdh/laravel-debugbar/blob/master/src/SymfonyHttpDriver.php#L51


Hope it can save at least a little bit of hunting around :)

@barryvdh
Copy link
Owner

barryvdh commented Jan 5, 2017

Thanks, up for a PR? ;)

@martindilling
Copy link
Contributor Author

#583
Don't know if it's good or not, but at least the application starts up in both 5.3 and 5.4 :)

@stale
Copy link

stale bot commented Jul 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this issue is still present on the latest version of this library on supported Laravel versions, please let us know by replying to this issue so we can investigate further.
Thank you for your contribution! Apologies for any delayed response on our side.

@stale stale bot added the stale label Jul 29, 2020
@stale stale bot closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants