Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.pull-right and .pull-left not namespaced to phpdebugbar #855

Closed
SlyDave opened this issue Aug 2, 2018 · 0 comments
Closed

.pull-right and .pull-left not namespaced to phpdebugbar #855

SlyDave opened this issue Aug 2, 2018 · 0 comments

Comments

@SlyDave
Copy link

SlyDave commented Aug 2, 2018

It looks like phpdebugbar includes a copy of bootstrap 3 and fontawesome 4.3 but namespaces all of the class selectors to stop conflict with a pages own stylesheet information.

e.g. .phpdebugbar-fa {

Unfortunately .pull-right and .pull-left haven't been namespaced and they are used in bootstrap3 but have been removed from bootstrap 4, this means if you are using bootstrap 4 and use pull-right/pull-left (as your IDE might autocomplete saying they're available) when the debug bar is disabled (for example in production) they don't work and your layout breaks.

Ideally phpdebugbar would be upgraded to use fontawesome 5 and bootstrap 4.

But for now a fix is to add the missing namespace to pull-right and pull-left as provided by debugbars stylesheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant