Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .pull-left, .pull-right from FA css #878

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

tomlankhorst
Copy link
Contributor

Avoid polluting CSS's 'global namespace'.
#855

Avoid polluting CSS's 'global namespace'
@SlyDave
Copy link

SlyDave commented Oct 11, 2018

Just remove them isn't enough? Isn't the Debug bar using these classes. If you remove them and aren't using bootstrap 3. The Debug bar won't display correctly?

@tomlankhorst
Copy link
Contributor Author

tomlankhorst commented Oct 11, 2018

A grep on the source does not show usages:

➜  laravel-debugbar git:(master) grep -ri "pull-\(left\|right\)" .
./src/Resources/vendor/font-awesome/style.css:.pull-right {
./src/Resources/vendor/font-awesome/style.css:.pull-left {
./src/Resources/vendor/font-awesome/style.css:.phpdebugbar-fa.pull-left {
./src/Resources/vendor/font-awesome/style.css:.phpdebugbar-fa.pull-right {

@barryvdh barryvdh merged commit 61f3be9 into barryvdh:master Oct 23, 2018
@crashkonijn
Copy link

Came here to ask for this, we just spent an hour trying to figure out why the site looked different on production with the exact same files.

Nice work!

@tomlankhorst
Copy link
Contributor Author

@crashkonijn Been there ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants