Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ide links full path #1224

Merged
merged 2 commits into from Nov 4, 2021

Conversation

macbookandrew
Copy link
Contributor

Thanks for an awesome dev helper utility! This is a minor suggestion to improve DX for the Views panel.

Problem: the “link” icon to an IDE (VS Code specifically) contains a relative path to the project root, but VS Code tells me that a file does not exist. It seems to expect an absolute path on the filesystem.

Solution: provide an absolute path to the file instead of a relative path.

@barryvdh barryvdh merged commit 7c05586 into barryvdh:master Nov 4, 2021
@andrewminion-luminfire andrewminion-luminfire deleted the feature/ide-links-full-path branch November 4, 2021 13:19
@barryvdh
Copy link
Owner

The tests didn't run properly, skipped them with #1256 for now. I think it relies on the specific format being available, so maybe set that in the setUp()?
Also trailing comma was not for older PHP versions.

andrewminion-luminfire pushed a commit to macbookandrew/laravel-debugbar that referenced this pull request Nov 12, 2021
@macbookandrew macbookandrew mentioned this pull request Nov 12, 2021
barryvdh pushed a commit that referenced this pull request Feb 11, 2024
* set xdebug ini

See #1224 (comment)

* remove check for xdebug support

* use ini_set for phpunit 8.5.x

* Revert "remove check for xdebug support"

This reverts commit e25e46e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants