Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated TwigCollector #1580

Merged
merged 1 commit into from Mar 21, 2024
Merged

Remove deprecated TwigCollector #1580

merged 1 commit into from Mar 21, 2024

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Mar 20, 2024

@barryvdh
Copy link
Owner

Hmm tests seem not to happy about this.

@erikn69
Copy link
Contributor Author

erikn69 commented Mar 20, 2024

Works on a real app, but for tests, that path not exists

base_path has

  • vendor
    . laravel-debugbar
    . php-debugbar

But on test

  • laravel-debugbar
    . vendor/php-debugbar

Maybe using ReflectionClass, I'm going to try it

@barryvdh
Copy link
Owner

Do we need the path? In the other collectors that isn't used?

@erikn69 erikn69 force-pushed the patch-71 branch 2 times, most recently from fadfbd7 to 883db9d Compare March 20, 2024 20:02
@erikn69
Copy link
Contributor Author

erikn69 commented Mar 20, 2024

Do we need the path? In the other collectors that isn't used?

You are right, not needed, At first it gave me a problem, but maybe it was the browser

@barryvdh barryvdh merged commit 8a26490 into barryvdh:master Mar 21, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikn69 @barryvdh