Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream twig extensions #1599

Merged
merged 1 commit into from Apr 1, 2024
Merged

Upstream twig extensions #1599

merged 1 commit into from Apr 1, 2024

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Apr 1, 2024

It would be an idea to remove a lot of code, and php-debugbar already left behind the old syntax
#632
https://github.com/rcrowe/TwigBridge/blob/4c256648cdc436fdd223e08ab1b8605b6fe75896/composer.json#L18-L19

@barryvdh
Copy link
Owner

barryvdh commented Apr 1, 2024

Is the compatibe with the old version? Or are user changes required.

@erikn69
Copy link
Contributor Author

erikn69 commented Apr 1, 2024

It should be fully compatible,
I gave it a quick check with https://github.com/rcrowe/TwigBridge and it didn't give me any problems

works with the same commands/tags

@barryvdh barryvdh merged commit c3f7489 into barryvdh:master Apr 1, 2024
25 checks passed
@barryvdh
Copy link
Owner

barryvdh commented Apr 1, 2024

Hmm I don't it always works, because of the order. The collectors are not added yet in the case I'm trying. See #1600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants