-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI refinements #1601
Merged
Merged
UI refinements #1601
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
282b8b3
wip
nckrtl c6745a0
Merge branch 'master' of https://github.com/barryvdh/laravel-debugbar…
nckrtl 2ad2ade
additional tweaks
nckrtl 32aa7bf
wip
nckrtl 2665aaa
add backgorund on odd rows in light mode for timeline tab
nckrtl 7d35ace
Bring back table borders for the timeline tab + fix line height in th…
nckrtl 6a05cd6
Remove fixed height of first child of the list item
nckrtl 73fdd64
remove odd background color for table rows at the timeline
nckrtl 7c08050
Fix alignment of arrays and text in key value lists
nckrtl 0e8669d
undo change regarding laravel icon
nckrtl 10ee2a4
Merge branch 'master' of https://github.com/nckrtl/laravel-debugbar i…
nckrtl 10849a1
additional tweaks
nckrtl f67d77a
undo css addtions + remove unnessary padding of pre in dd elements
nckrtl e37b451
css cleanup + bring back laravel icon in debugbar popup / open window
nckrtl edb2ef9
better center alignment of the phpdebugbar-header-right items
nckrtl 9418bfe
cleanup changes that can be moved to the base package
nckrtl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe here??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I added that to make the text in the timeline waterfall better readable on blue background:
With the text shadow:
But quite some elements are affected by that change, perhaps too many:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are many classes involved(also main
div.phpdebugbar
), I saw it everywhere.