Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require dompdf through Composer #6

Closed
philsturgeon opened this issue Jul 30, 2013 · 3 comments
Closed

Require dompdf through Composer #6

philsturgeon opened this issue Jul 30, 2013 · 3 comments

Comments

@philsturgeon
Copy link

Creating a wrapper for L4 is a nice idea, but you really shouldn't be modifying the original package which you are wrapping!

Just lits it as a dependency in your package.

https://github.com/dompdf/dompdf

It's right here, so its easy to install.

@philsturgeon
Copy link
Author

Sorry, you are. Ignore this.

@barryvdh
Copy link
Owner

Maybe you meant this package? https://github.com/thujohn/pdf-l4

@philsturgeon
Copy link
Author

No I just looked at the PDF class and responded too quickly. I'm spring-loaded on "shout at people making L4 specific code which shouldn't be L4 specific" and "wrappers should be wrappers not forks", and pulled the trigger to quickly.

Good work :)

Sent from my iPhone

On Jul 31, 2013, at 3:15 AM, "Barry vd. Heuvel" notifications@github.com wrote:

Maybe you meant this package? https://github.com/thujohn/pdf-l4


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants