Check for traits recursively #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
reviewed
Apr 30, 2021
|
@mfn I've added a test 👍 |
mfn
approved these changes
Apr 30, 2021
Co-authored-by: Markus Podar <markus@fischer.name>
|
@mfn I've updated the changelog, not sure if this is what you meant? |
mfn
approved these changes
May 1, 2021
|
The failed test is a result of composer timeout; I'd assume it's temporary thing and the build is fine. |
|
Hmm, we've the same failing jobs now in #1185 too |
6 tasks
mfn
added a commit
to mfn/laravel-ide-helper
that referenced
this pull request
May 3, 2021
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh#1076 See also: - barryvdh#1216 (comment) - barryvdh#1185 (comment)
9 tasks
barryvdh
pushed a commit
that referenced
this pull request
Jun 20, 2021
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of #1076 See also: - #1216 (comment) - #1185 (comment)
fatihdirikman
added a commit
to fatihdirikman/Laravel-IDE-Helper
that referenced
this pull request
Jan 7, 2022
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
renaforsberg824
added a commit
to renaforsberg824/ide-helper-laravel-developer
that referenced
this pull request
Oct 5, 2022
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
lisadeloach63
added a commit
to lisadeloach63/ide-helper-reso-laravel
that referenced
this pull request
Oct 7, 2022
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
sadafrangian3
pushed a commit
to sadafrangian3/ide-helper-laravel
that referenced
this pull request
Oct 18, 2022
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
smile1130
added a commit
to smile1130/laravel-IDE
that referenced
this pull request
Jun 16, 2023
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh/laravel-ide-helper#1076 See also: - barryvdh/laravel-ide-helper#1216 (comment) - barryvdh/laravel-ide-helper#1185 (comment)
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
IMHO it's impractical to expect this package to have to work with the "first release of Laravel for any major release" even when there are already sever more releases: no one is/should stick to that version. This is a re-submit of barryvdh#1076 See also: - barryvdh#1216 (comment) - barryvdh#1185 (comment)
d3v2a
pushed a commit
to d3v2a/laravel-ide-helper
that referenced
this pull request
Feb 16, 2024
* Check for traits recursively * Remove autoload bool from class_uses_recursive * Add test * Update src/Console/ModelsCommand.php Co-authored-by: Markus Podar <markus@fischer.name> * Updated changelog Co-authored-by: Markus Podar <markus@fischer.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parent traits are not checked when checking for HasFactory or Macroable traits.
E.g; My models extend an AbstractModel which implements the HasFactory trait, but no documentation is added.
Type of change
Checklist
composer fix-style