Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Castables issue #1312 #1388

Merged
merged 5 commits into from Feb 4, 2023
Merged

Fix Castables issue #1312 #1388

merged 5 commits into from Feb 4, 2023

Conversation

kwarcu
Copy link
Contributor

@kwarcu kwarcu commented Nov 9, 2022 •
edited

Summary

Fix for issue with Castables described in #1312
If type of a Castable can not be determined from return type of get method from castUsing()->CastsAttributes then the original Castable class should be used.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Code style has been fixed via composer fix-style
  • Add a CHANGELOG.md entry

@kwarcu kwarcu mentioned this pull request Nov 9, 2022
Closed
@code-distortion code-distortion mentioned this pull request Jan 2, 2023
Open
9 tasks
mfn
mfn approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please don't ignore the PR template and add a changelog entry 🙏🏼

@kwarcu kwarcu closed this Feb 2, 2023
@kwarcu kwarcu reopened this Feb 2, 2023
@kwarcu
Copy link
Contributor Author

kwarcu commented Feb 2, 2023

LGTM, but please don't ignore the PR template and add a changelog entry 🙏🏼

Thanks and sorry, that's my first ever PR to an Open Source repo so I'm not always sure about the protocol. I added the CHANGELOG.md entry.

mfn
mfn approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌🏼

@barryvdh barryvdh merged commit 81d5b22 into barryvdh:master Feb 4, 2023
@barryvdh
Copy link
Owner

barryvdh commented Feb 4, 2023

Thanks!

@Jefemy Jefemy mentioned this pull request Feb 19, 2023
Closed
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
@kwarcu @d3v2a
Fix Castables issue barryvdh#1312 (barryvdh#1388)
94b8bad 
* Return Castable class if failed to detect it from return types

* fix-style

* Add CHANGELOG.md entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfn mfn mfn approved these changes

Assignees

@barryvdh barryvdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kwarcu @barryvdh @mfn