Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix belongsTo relation is detected as nullable. #1461

Merged
merged 1 commit into from Feb 7, 2024

Conversation

snmatsui
Copy link
Contributor

Summary

In ModelsCommand, belongs to relations are detected as nullable when this column is nullable or has not foreign key constraint.

https://github.com/barryvdh/laravel-ide-helper/blob/master/src/Console/ModelsCommand.php#L841-L842

Now read foreign keys is not reset on model loop.
For example. when column x of model A has no foreign key and column x of model B has foreign key, column x of model A may marked as not nullable because column x is recoreded as foreign key by model B.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@barryvdh barryvdh closed this Feb 7, 2024
@barryvdh barryvdh reopened this Feb 7, 2024
@barryvdh
Copy link
Owner

barryvdh commented Feb 7, 2024

Thanks, seems like an oversight indeed.

@barryvdh barryvdh merged commit c290af8 into barryvdh:master Feb 7, 2024
33 checks passed
d3v2a pushed a commit to d3v2a/laravel-ide-helper that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants