Merge reset/smart reset, don't set class #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why this is like it is, but it kind a feels odd. |
mfn
approved these changes
Feb 19, 2024
|
Yeah I guess we could, maybe slightly annoying but it's allowed I suppose |
mfn
added a commit
to mfn/laravel-ide-helper
that referenced
this pull request
Feb 19, 2024
mfn
added a commit
to mfn/laravel-ide-helper
that referenced
this pull request
Feb 19, 2024
barryvdh
added a commit
that referenced
this pull request
Feb 19, 2024
* Remove `--smart-reset` completely See #1523 (comment) * Update CHANGELOG.md --------- Co-authored-by: Barry vd. Heuvel <barryvdh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of having reset and smart-reset, just reset and never change the test. I don't really see why we should mention the classname in the phpdocs? So just leave the text be, or empty?
Type of change
Checklist
composer fix-style