Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for AsEnumCollection casts #1557

Merged
merged 8 commits into from
Jul 12, 2024
Merged

Conversation

Braunson
Copy link
Contributor

@Braunson Braunson commented Jun 10, 2024

Summary

This adds support for the AsEnumCollection casts. Referenced in the Laravel documentation.

This references #1553

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing.

Please remove any non-code (aka: whitespace) changes.

It helps if you try running the test suite locally

@Braunson Braunson requested a review from mfn June 11, 2024 13:07
@Braunson
Copy link
Contributor Author

Just a heads up @mfn the composer fix-style command is what is adding the strict types so I didn't commit any changes from it. If that's in the docs to run, you may want to either accept that change or update the php-cs-fixer rules.

Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

Thanks regarding the fix-style, wasn't aware!

@mfn mfn requested a review from barryvdh June 12, 2024 05:11
@mfn mfn mentioned this pull request Jun 12, 2024
9 tasks
@barryvdh barryvdh merged commit 672acce into barryvdh:master Jul 12, 2024
26 checks passed
@barryvdh
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants