#13 More on types

barseghyanartur · Jun 12, 2021 · 305cf8f · 305cf8f
1 parent 3576509
commit 305cf8f
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 4 deletions.
diff --git a/src/ska/contrib/django/ska/backends/constance_backend.py b/src/ska/contrib/django/ska/backends/constance_backend.py
@@ -1,8 +1,11 @@
 import json
+from typing import Dict, Optional, Union
 
 from constance import config
 
 from django.conf import settings
+from django.http import HttpRequest
+from rest_framework.request import Request
 
 from .base import BaseSkaAuthenticationBackend
 
@@ -15,7 +18,14 @@
 class SkaAuthenticationConstanceBackend(BaseSkaAuthenticationBackend):
     """Authentication backend."""
 
-    def get_settings(self, request_data=None, request=None, **kwargs):
+    def get_settings(
+        self,
+        request_data: Optional[
+            Dict[str, Union[bytes, str, float, int]]
+        ] = None,
+        request: Optional[Union[Request, HttpRequest]] = None,
+        **kwargs,
+    ) -> Dict[str, Dict[str, str]]:
         """Get settings.
 
         :return:
@@ -31,7 +41,14 @@ def get_settings(self, request_data=None, request=None, **kwargs):
                 pass
         return config.SKA_PROVIDERS
 
-    def get_secret_key(self, request_data=None, request=None, **kwargs):
+    def get_secret_key(
+        self,
+        request_data: Optional[
+            Dict[str, Union[bytes, str, float, int]]
+        ] = None,
+        request: Optional[Union[Request, HttpRequest]] = None,
+        **kwargs,
+    ) -> str:
         """Get secret key.
 
         :return:

diff --git a/src/ska/contrib/django/ska/backends/default_backends.py b/src/ska/contrib/django/ska/backends/default_backends.py
@@ -1,3 +1,7 @@
+from typing import Any, Dict, Optional, Union
+from django.http import HttpRequest
+from rest_framework.request import Request
+
 from .base import BaseSkaAuthenticationBackend
 
 __author__ = "Artur Barseghyan <artur.barseghyan@gmail.com>"
@@ -9,14 +13,28 @@
 class SkaAuthenticationBackend(BaseSkaAuthenticationBackend):
     """Authentication backend."""
 
-    def get_settings(self, request_data=None, request=None, **kwargs):
+    def get_settings(
+        self,
+        request_data: Optional[
+            Dict[str, Union[bytes, str, float, int]]
+        ] = None,
+        request: Optional[Union[Request, HttpRequest]] = None,
+        **kwargs,
+    ) -> Dict[Any, Any]:
         """Get settings.
 
         :return:
         """
         return {}
 
-    def get_secret_key(self, request_data=None, request=None, **kwargs):
+    def get_secret_key(
+        self,
+        request_data: Optional[
+            Dict[str, Union[bytes, str, float, int]]
+        ] = None,
+        request: Optional[Union[Request, HttpRequest]] = None,
+        **kwargs,
+    ) -> None:
         """Get secret key.
 
         :return: