Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for new Brazilian TLDs #92

Closed
wants to merge 2 commits into from
Closed

Adding support for new Brazilian TLDs #92

wants to merge 2 commits into from

Conversation

paduanton
Copy link

In the 20 july 2020 the main Brazilian department responsible for national domains added new tlds to purchase domains, so this PR aims to add support to them.
You can check the official documentation in the link below.

References: https://registro.br/dominio/categorias/

@paduanton paduanton changed the title Adding support for new brazilian TLDs Adding support for new Brazilian TLDs Jul 24, 2020
@barseghyanartur
Copy link
Owner

@paduanton:

Thanks. I appreciate the effort and although your PR is totally correct, I'm closing it without merging. Let me explain why. The data file (.dat) is taken from public suffix. Even if I do merge your PR, the changes would be gone after first attempt to update the data. I suggest you open a PR or raise an issue in PublicSuffix repositoru.

@paduanton
Copy link
Author

Oh, I see. Tell me something, after the data is updated in the PublicSuffix repository. Is it required any change in this repository of yours or somehow this repo is gonna be updated automatically?

@barseghyanartur
Copy link
Owner

Look, there's a update-tld-names command, which you run locally (after installing the library in your environment) and it pulls the latest changes in the public suffix list locally. Every release of this library, comes with the latest public suffix updated as well.

@paduanton
Copy link
Author

paduanton commented Jul 24, 2020

PublicSuffix already has the new Brazilian top-level domains. It was added 12 days ago.

I look forward to your next release, so I can update the lib in my application to use the new tlds.

Thank you.

@barseghyanartur
Copy link
Owner

I don't know when the next release would be, but if public suffix list has been updated, you simply need to run the following command in your virtual environment to have it available:

update-tld-names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants