Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to tzinfo #61

Closed
wants to merge 3 commits into from
Closed

Add support to tzinfo #61

wants to merge 3 commits into from

Conversation

rougeth
Copy link
Contributor

@rougeth rougeth commented May 14, 2014

When time zone support is disabled, Django uses naive datetime objects in local time. [...] When time zone support is enabled, Django uses time-zone-aware datetime objects.

The problem was that datetime.datetime.now() always return a naive datetime object and, in my case, time zone was enabled.

django.utils.timezone.now() check USE_TZ and returns a proper object.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d7e5df8 on colab-community:master into 3944c4d on bartTC:master.

@bartTC
Copy link
Collaborator

bartTC commented Jun 8, 2014

Thank you. I cherry-picked your change from above pull request. Due to maintenance issues I had in the past I'm not keen in to include other languages in the app right now.

@bartTC bartTC closed this Jun 8, 2014
@rougeth
Copy link
Contributor Author

rougeth commented Aug 7, 2014

@bartTC, Could you explain me what problems did you have with i18n, so that we can find a solution to it? I can't see a problem and having Dpaste (not a fork) in Portuguese would make my life easier. (:

@rougeth
Copy link
Contributor Author

rougeth commented Aug 25, 2014

@bartTC ?

@seocam
Copy link
Contributor

seocam commented Sep 29, 2014

@bartTC is that your final word about localization?

@bartTC
Copy link
Collaborator

bartTC commented Sep 29, 2014

Yes, and no. I was looking into https://www.transifex.com/ on how to optimize and automate the whole procedure. Give me some time please.

@seocam
Copy link
Contributor

seocam commented Sep 29, 2014

@bartTC I'm working with a university in Brazil and we are using your lib in the a project for our Federal Senate and also in the Ministry of Planing.

Unfortunately we can't afford to have the dpase in English (we are even doing the translation work for Gitlab).

Currently we are installing dpaste from our fork but one of my tasks today is to ensure we don't install things directly from the repos.

If you need help to maintain the i18n of your project I can step in to help. Is it ok if I open a new PR with @rougeth 's translations?

Cheers!

@seocam
Copy link
Contributor

seocam commented Oct 15, 2014

@bartTC any updates?

I'm currently working on forking dpaste (as I was told to) but that seems so much waste of time and effort.
I can volunteer to manage the translations in Transifex so you don't have to spend time on that. I'm sorry to insist but I'm not happy with the idea of maintaining a fork if I could use this time to actually help the upstream project.

@bartTC
Copy link
Collaborator

bartTC commented Oct 15, 2014

@seocam I'd love to have help with translations. The problem I have is less the merges, those are easy. it's hunting people before a new release, in case string is added or changed.

Transifex kinda solves this problem because it's huge userbase and simple interface.

But if you can do that instead, I'd be thankful. I'll give you repo access.

@rougeth
Copy link
Contributor Author

rougeth commented Oct 15, 2014

@bartTC @seocam 👍👍👍

@seocam
Copy link
Contributor

seocam commented Oct 16, 2014

awesome! I'm already creating the org and project on Transifex.

Thanks @bartTC!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants