Fix exception thrown for connection issue #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the smtp connection fails an exception will be thrown at line 344. It is something along the lines
stream_set_timeout() expected object but got bool. Thus theconnect()function throws an exception instead of returning false.The consequence is that the smtp connection is not closed in
PHPMailer::2051. Also the exception is not aConnectivityExceptionas should be the case throughPHPMailer::1859andMailer::157.The added piece of code I added is part of the latest stable release of PHPMailer so should be safe.