Skip to content

Commit

Permalink
apply unified code style
Browse files Browse the repository at this point in the history
  • Loading branch information
bartekczyz committed Jan 16, 2021
1 parent a0aaf1c commit 9b4f2b0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
6 changes: 6 additions & 0 deletions __tests__/pesel.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ describe('pesel', () => {
;[...validMales, ...validFemales].forEach((peselNumber) => {
it(`using ${peselNumber}`, () => {
const pesel = new PESEL(peselNumber)

expect(pesel.isValid).toEqual(true)
})
})
Expand All @@ -19,6 +20,7 @@ describe('pesel', () => {
;[...invalidMales, ...invalidFemales].forEach((peselNumber) => {
it(`using ${peselNumber}`, () => {
const pesel = new PESEL(peselNumber)

expect(pesel.isValid).toEqual(false)
})
})
Expand All @@ -28,13 +30,15 @@ describe('pesel', () => {
validMales.forEach((peselNumber) => {
it(`using valid ${peselNumber}`, () => {
const pesel = new PESEL(peselNumber)

expect(pesel.getGender()).toEqual('male')
})
})

invalidMales.forEach((peselNumber) => {
it(`using invalid ${peselNumber}`, () => {
const pesel = new PESEL(peselNumber)

expect(pesel.getGender()).toEqual('male')
})
})
Expand All @@ -44,12 +48,14 @@ describe('pesel', () => {
validFemales.forEach((peselNumber) => {
it(`using valid ${peselNumber}`, () => {
const pesel = new PESEL(peselNumber)

expect(pesel.getGender()).toEqual('female')
})
})
invalidFemales.forEach((peselNumber) => {
it(`using valid ${peselNumber}`, () => {
const pesel = new PESEL(peselNumber)

expect(pesel.getGender()).toEqual('female')
})
})
Expand Down
6 changes: 2 additions & 4 deletions src/nip/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export class NIP {
private readonly valid: boolean

private readonly nip: string

constructor(nip: string) {
Expand All @@ -23,10 +24,7 @@ export class NIP {
const weights = [6, 5, 7, 2, 3, 4, 5, 6, 7]
const digits = `${this.nip}`.split('').map((digit) => +digit)
const lastDigit = digits.splice(-1)[0]
const control = weights.reduce(
(previous, current, index) => previous + current * digits[index],
0
)
const control = weights.reduce((previous, current, index) => previous + current * digits[index], 0)

return control % 11 === lastDigit
}
Expand Down
4 changes: 1 addition & 3 deletions src/pesel/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,7 @@ export class PESEL {
const weights = [1, 3, 7, 9]
const digits = `${this.pesel}`.split('').map((digit) => +digit)
const lastDigit = digits.splice(-1)[0]
const control =
digits.reduce((previous, current, index) => previous + current * weights[index % 4]) %
10
const control = digits.reduce((previous, current, index) => previous + current * weights[index % 4]) % 10

return 10 - (control === 0 ? 10 : control) === lastDigit
}
Expand Down

0 comments on commit 9b4f2b0

Please sign in to comment.