Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warning about an unstopped app in the Demo server #1137

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

bartfeenstra
Copy link
Owner

Fix a warning about an unstopped app in the Demo server by ensuring the app is stopped even if an error is raised.

…he app is stopped even if an error is raised.
@bartfeenstra bartfeenstra added the bug Something isn't working label Jan 7, 2024
@bartfeenstra bartfeenstra added this to the 0.3.0 milestone Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (932b0ed) 92.46% compared to head (a550665) 92.47%.
Report is 1 commits behind head on 0.3.x.

Files Patch % Lines
betty/extension/demo/__init__.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1137      +/-   ##
==========================================
+ Coverage   92.46%   92.47%   +0.01%     
==========================================
  Files          74       74              
  Lines        8481     8483       +2     
==========================================
+ Hits         7842     7845       +3     
+ Misses        639      638       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 7, 2024

Uploaded Betty for commit a550665. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra merged commit d4cbba7 into 0.3.x Jan 7, 2024
10 of 11 checks passed
@bartfeenstra bartfeenstra deleted the fix-unstopped-app-warning-in-demo-server branch January 7, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant