Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] undefined image.size #24

Closed
3 tasks done
barthofu opened this issue Aug 19, 2022 · 0 comments · Fixed by #27
Closed
3 tasks done

[Bug] undefined image.size #24

barthofu opened this issue Aug 19, 2022 · 0 comments · Fixed by #27
Assignees
Labels
bug Something isn't working
Milestone

Comments

@barthofu
Copy link
Owner

barthofu commented Aug 19, 2022

What happened?

When the automaticUploadImagesToImgur option is set to true but no imgur client_id is referenced in the .env, the upload to imgur fails and some properties of the Image entity are not defined.

image

Fixes todo:

  • turn off by default the option in the config
  • add a special handling in case of failure of the upload in the service
  • in the check before the call of the service (in the main.ts), don't just check if the IMGUR_CLIENT_ID env variable is set but that's also different from the default value of the .env.example

Reproduction

  1. Set automaticUploadImagesToImgur config option to true
  2. Set the IMGUR_CLIENT_ID env variable as an invalid client_id
  3. Add an image in the assets/ folder
  4. Start the bot

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@barthofu barthofu added the bug Something isn't working label Aug 19, 2022
@barthofu barthofu self-assigned this Aug 19, 2022
@barthofu barthofu added this to the v1.1 milestone Aug 19, 2022
@barthofu barthofu linked a pull request Aug 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant