Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow refresh_token to be absent in response #177

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justinp
Copy link

@justinp justinp commented Feb 26, 2022

This failed for me in a refresh token response from Spotify (using spotify4s) because they don't include refresh_token.

@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Base: 67.96% // Head: 67.84% // Decreases project coverage by -0.12% ⚠️

Coverage data is based on head (7c93e36) compared to base (63c0030).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   67.96%   67.84%   -0.13%     
==========================================
  Files          15       15              
  Lines         256      255       -1     
  Branches        7        7              
==========================================
- Hits          174      173       -1     
  Misses         82       82              
Impacted Files Coverage Δ
...bartholomews/fsclient/circe/FsClientCirceApi.scala 75.00% <100.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant