Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PostgresDialectConfig. #2

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

thorwebdev
Copy link
Contributor

Thanks for your awesome work on this @barthuijgen it helped me a lot! Made some changes that I think could be helpful. Would be great if you could take a look :)

@barthuijgen
Copy link
Owner

Thanks! I'll take a look soon and merge this in. I don't actively use this package anymore but glad it was helpful

@thorwebdev
Copy link
Contributor Author

Thanks @barthuijgen, appreciate it. Let me know if you're looking to transfer the repo over to someone else. I might be able to take it on if that's the case.

@barthuijgen barthuijgen merged commit 7c1b3cb into barthuijgen:main Apr 19, 2023
@barthuijgen
Copy link
Owner

I don't think there is much value left in the way this adapter package is set up.

Since I published this the official package made it easier to adopt the library in a non nodejs environment. See the deno example at https://github.com/kysely-org/kysely#deno The only thing you need now is the PostgresDriver while everything else can be imported from kysely directly.

https://gist.github.com/barthuijgen/65e96bbc276d1f62c538af6cbaa9ea6c

In my last project I just used this, instead of depending on an extra dependency.

Regardless, I merged your MR. thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants