only enable with DENO_FUTURE

bartlomieju · May 6, 2024 · 4186e73 · 4186e73
1 parent 74d794c
commit 4186e73
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 3 deletions.
diff --git a/cli/args/mod.rs b/cli/args/mod.rs
@@ -557,6 +557,12 @@ fn discover_npmrc(
   maybe_package_json_path: Option<PathBuf>,
   maybe_deno_json_path: Option<PathBuf>,
 ) -> Result<Arc<ResolvedNpmRc>, AnyError> {
+  // Only support discovering `.npmrc` with `DENO_FUTURE` to not break existing
+  // workflows.
+  if !*DENO_FUTURE {
+    return Ok(create_default_npmrc());
+  }
+
   const NPMRC_NAME: &str = ".npmrc";
 
   fn get_env_var(var_name: &str) -> Option<String> {

diff --git a/tests/specs/npm/npmrc/__test__.jsonc b/tests/specs/npm/npmrc/__test__.jsonc
@@ -1,5 +1,8 @@
 {
   "tempDir": true,
   "args": "run -A main.js",
+  "envs": {
+    "DENO_FUTURE": "1"
+  },
   "output": "main.out"
 }
diff --git a/tests/specs/npm/npmrc_bad_token/__test__.jsonc b/tests/specs/npm/npmrc_bad_token/__test__.jsonc
@@ -2,5 +2,8 @@
   "tempDir": true,
   "args": "run -A main.js",
   "output": "main.out",
-  "exitCode": 1
+  "exitCode": 1,
+  "envs": {
+    "DENO_FUTURE": "1"
+  }
 }
diff --git a/tests/specs/npm/npmrc_deno_json/__test__.jsonc b/tests/specs/npm/npmrc_deno_json/__test__.jsonc
@@ -1,5 +1,8 @@
 {
   "tempDir": true,
   "args": "run -A main.js",
-  "output": "main.out"
+  "output": "main.out",
+  "envs": {
+    "DENO_FUTURE": "1"
+  }
 }
diff --git a/tests/specs/npm/npmrc_not_next_to_package_json/__test__.jsonc b/tests/specs/npm/npmrc_not_next_to_package_json/__test__.jsonc
@@ -1,5 +1,8 @@
 {
   "tempDir": true,
   "args": "run -A -L debug subdir/main.js",
-  "output": "main.out"
+  "output": "main.out",
+  "envs": {
+    "DENO_FUTURE": "1"
+  }
 }