Update Emacs integration and interaction with modern git. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`(vc-backend)` is the symbol `GIT` in some versions of Emacs. Rather than just comparing it with the fixed case string, case-fold it for comparison. This makes the detection of the back-end much more robust - extracting the logic to determine if the buffer is managed by git, then using that in all the hooks. Signed-off-by: Daniel Pittman <daniel@rimspace.net>
In modern git installations, most of the `git-whatever` commands are hidden well away from the user - and so are the support components like the shell setup libraries and so forth. That means that invoking `git-wip` directly fails, but `git wip` will do exactly the right thing. Since the cost of invoking it that way is low, we might as well... Signed-off-by: Daniel Pittman <daniel@rimspace.net>
A copy-and-paste error would output the wrong branch when there are no commits found.
|
+1 for these fixes! |
|
@daniel-pittman If you like git-wip you might also like https://github.com/magit/magit/blob/master/magit-wip.el :-) |
|
+1000 for magit-wip :) |
|
just cleaning up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the code, based on next, to work with Emacs 23.1, and to work with a modern git through invoking
git wiprather thangit-wipdirectly.As a bonus, it has a minor fix to error reporting for
git wip log.