Skip to content

Upgrade to RN 29.2

Compare
Choose a tag to compare
@bartonhammond bartonhammond released this 21 Jul 21:39
· 115 commits to master since this release

Many, many thanks to @wookiem !!!! Don't know what I would have done w/o your help!!!!

Notes

  • Once you merge the Snowflake, due to RN 25 issues, updates you'll need to modify any additional react files in your project:
    Instead of:
import React, { Component, PropTypes, View } from 'react-native';

you need to now use:

import React, { Component, PropTypes } from 'react';
import { View } from 'react-native';
  • In an effort to keep up w/ the releases of RN, this release is sub-par for Snowflake. There are a number of issues that have to be addressed. I will get to them in the coming days. My immediate concern is trying to get Snowflake in sync w/ RN releases.
  • This release contains buck configuration stuff but it's not completed.
  • One of the missing features is the SessionToken support.

Please review the following.

There are 3 tests were blocked by other projects:

This is temporarily fixed w/ https://github.com/bartonhammond/snowflake-react-native-button

The following two tests were failing:

FAIL  src/components/__tests__/FormButton-test.js (0s)
 Runtime Error
  - TypeError: Cannot read property 'style' of undefined
        at Object.<anonymous> (node_modules/apsl-react-native-button/Button.js:22:25)

and the other:

 FAIL  src/components/__tests__/Header-test.js (0s)
 Runtime Error
  - TypeError: Cannot read property 'style' of undefined
        at Object.<anonymous> (node_modules/apsl-react-native-button/Button.js:22:25)

The other failure is waiting on gcanti/tcomb-form-native#134 so the file has been renamed

 FAIL  src/components/__tests__/LoginForm-test.js (0s)
 Runtime Error
  - Error: Cannot find module './datepicker' from 'index.js'
        at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:197:17)
        at Runtime._resolveModule (node_modules/jest-runtime/build/index.js:327:32)
        at Runtime._normalizeID (node_modules/jest-runtime/build/index.js:492:31)
        at Runtime._shouldMock (node_modules/jest-runtime/build/index.js:536:27)
        at Runtime.requireModuleOrMock (node_modules/jest-runtime/build/index.js:271:14)
        at Object.<anonymous> (node_modules/tcomb-form-native/lib/templates/bootstrap/index.js:5:12)
        at Runtime._execModule (node_modules/jest-runtime/build/index.js:375:17)
        at Runtime.requireModule (node_modules/jest-runtime/build/index.js:210:14)
        at Runtime.requireModuleOrMock (node_modules/jest-runtime/build/index.js:274:19)
        at Object.<anonymous> (node_modules/tcomb-form-native/index.js:3:16)