Skip to content

Commit

Permalink
Updated CI pipeline for compile target
Browse files Browse the repository at this point in the history
  • Loading branch information
bartoszlenar committed May 22, 2024
1 parent a4963a3 commit 107f7f8
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 23 deletions.
4 changes: 1 addition & 3 deletions .github/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -528,9 +528,7 @@ Before publishing, each release is tested on the ["latest" version](https://help

using the upcoming, the current and all also the supported [LTS versions](https://dotnet.microsoft.com/platform/support/policy/dotnet-core) of the underlying frameworks:

* .NET 7.0 (RC1)
* .NET 6.0
* .NET Core 3.1
* .NET 8.0
* .NET Framework 4.8 (Windows only)

### Performance
Expand Down
33 changes: 13 additions & 20 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,18 @@ jobs:
strategy:
matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
dotnet: ['3.1.x', '6.0.x', '7.0.100-rc.1.22431.12']
dotnet: ['8.0.4']
runs-on: ${{ matrix.os }}
name: Test on ${{ matrix.os }} using dotnet ${{ matrix.dotnet }}
steps:
- name: Check out code
uses: actions/checkout@v2
- name: Setup base dotnet sdk
uses: actions/setup-dotnet@v1
uses: actions/checkout@v4
- name: Setup dotnet
uses: actions/setup-dotnet@v4
with:
dotnet-version: '6.0.x'
- name: Setup target dotnet sdk
if: matrix.dotnet != '6.0.x'
uses: actions/setup-dotnet@v1
with:
dotnet-version: ${{ matrix.dotnet }}
dotnet-version: |
8.0.4
${{ matrix.dotnet }}
- name: Init workflow variables
run: pwsh .github/workflows/Init-WorkflowVariables.ps1
- name: Compile
Expand All @@ -53,9 +50,9 @@ jobs:
- name: Check out code
uses: actions/checkout@v2
- name: Setup base dotnet sdk
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
with:
dotnet-version: '6.0.x'
dotnet-version: '8.0.4'
- name: Init workflow variables
run: pwsh .github/workflows/Init-WorkflowVariables.ps1
- name: Compile
Expand All @@ -77,13 +74,9 @@ jobs:
- name: Check out code
uses: actions/checkout@v2
- name: Setup base dotnet sdk
uses: actions/setup-dotnet@v1
with:
dotnet-version: '6.0.x'
- name: Setup dotnet sdk for global tool
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
with:
dotnet-version: '3.1.x'
dotnet-version: '8.0.4'
- name: Init workflow variables
run: pwsh .github/workflows/Init-WorkflowVariables.ps1
- name: Analyze code coverage
Expand Down Expand Up @@ -116,9 +109,9 @@ jobs:
- name: Checking out code
uses: actions/checkout@v2
- name: Setup base dotnet sdk
uses: actions/setup-dotnet@v1
uses: actions/setup-dotnet@v4
with:
dotnet-version: '6.0.x'
dotnet-version: '8.0.4'
- name: Init workflow variables
run: pwsh .github/workflows/Init-WorkflowVariables.ps1
- name: Create package
Expand Down
5 changes: 5 additions & 0 deletions build/Build.cs
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,11 @@ string GetFramework(string dotnet)
return "net7.0";
}

if (dotnet.StartsWith("8.0.", StringComparison.Ordinal))
{
return "net8.0";
}

Logger.Warn("Unrecognized dotnet SDK version: " + dotnet);

return dotnet;
Expand Down
4 changes: 4 additions & 0 deletions tests/Validot.Tests.Functional/.editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ dotnet_diagnostic.CA1310.severity = none
dotnet_diagnostic.CA1707.severity = none
dotnet_diagnostic.CA1847.severity = none
dotnet_diagnostic.CA1852.severity = none
dotnet_diagnostic.CA1859.severity = none
dotnet_diagnostic.CA1860.severity = none
dotnet_diagnostic.CA1861.severity = none
dotnet_diagnostic.CA1866.severity = none
dotnet_diagnostic.CA2237.severity = none

dotnet_diagnostic.SA1122.severity = none
Expand Down
3 changes: 3 additions & 0 deletions tests/Validot.Tests.Unit/.editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ dotnet_diagnostic.CA1825.severity = none
dotnet_diagnostic.CA1845.severity = none
dotnet_diagnostic.CA1847.severity = none
dotnet_diagnostic.CA1852.severity = none
dotnet_diagnostic.CA1859.severity = none
dotnet_diagnostic.CA1860.severity = none
dotnet_diagnostic.CA1861.severity = none

dotnet_diagnostic.SA1118.severity = none
dotnet_diagnostic.SA1122.severity = none
Expand Down

0 comments on commit 107f7f8

Please sign in to comment.