Update MNIST tutorial #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -198,8 +186,10 @@ During training we will want to monitor the performance of our model on | |||
| a separate set of examples. Let's create a new data stream for that. | |||
|
|
|||
| >>> mnist_test = MNIST("test") | |||
| >>> data_stream_test = DataStream(mnist_test, iteration_scheme=SequentialScheme( | |||
| ... mnist_test.num_examples, batch_size=1024)) | |||
| >>> data_stream_test = DataStream.default_stream( | |||
There was a problem hiding this comment.
Don't we need a Flatten here, like in blocks/examples/mnist.py?
There was a problem hiding this comment.
This good catch should have ideally been done by Travis. Can we somehow empty Travis cache? Now it is really dangerous: changes in Fuel are ignored when testing Blocks master and PRs.
There was a problem hiding this comment.
You're right. I'll clear the cache and restart the tests.
|
Oops, sorry, I didn't read that we are waiting for Fuel docs to be updated. But I guess they will be soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #627. Only thing needed before we merge is for Fuel's online doc to be refreshed.