Interface changes in genseq #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: blocks/graph.py
| @@ -73,8 +73,6 @@ class BaseSequenceGenerator(Initializeable): | |||
| average of the annotations. | |||
|
|
|||
| * For speech recognition we would have three: the weighted average, | |||
| the alignment and the monotonicity penalty. | |||
There was a problem hiding this comment.
Why do you want to remove this line from the comment?
There was a problem hiding this comment.
Oops, I don't.
|
What should with this PR, @dmitriy-serdyuk? |
|
I'm going to contunue the work and port to blocks the beam search I implemented for our inner project. |
|
Okay, I keep it open. I do not want to rush you, but this is the main missing part of the sequence generation framework (apart that it is badly documented, but I am working on that). So I will have to do it myself if you do not start soon. |
|
Sorry! Pressed wrong button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed interface of SequenceGenerator and Emitter for beam search.