-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve download function #118
Conversation
@@ -11,6 +12,22 @@ class NeedURLPrefix(Exception): | |||
pass | |||
|
|||
|
|||
@contextmanager | |||
def progress_bar(name, maxval): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm debating adding an additional dependency ( |
Probably a good call (running tests offline is kind of important for working on the road, and the UCI people probably do not appreciate our Travis bot hitting their server frequently), but save that for another PR. |
For tests you can add whatever you want I think, because the user won't On Sat, May 16, 2015 at 6:06 PM, vdumoulin notifications@github.com wrote:
|
Oh, and add them as an optional dependency in |
IIRC there's some sort of "tests_require" thing in setup.py, no? On Sat, May 16, 2015 at 6:08 PM, Bart van Merriënboer <
|
This PR adds a progress bar. Partially fixes #117.