Improve download function

[vdumoulin]

This PR adds a progress bar. Partially fixes #117.

[vdumoulin]

@dwf

[dwf]

[vdumoulin]

I'm debating adding an additional dependency (httmock) to mock HTTP requests. It allows to speed up the tests as well as craft responses that target specific cases in download helpers. Any thoughts?

[dwf]

Probably a good call (running tests offline is kind of important for working on the road, and the UCI people probably do not appreciate our Travis bot hitting their server frequently), but save that for another PR.

[bartvm]

For tests you can add whatever you want I think, because the user won't
have to install them. Just make sure to add them to req-travis-pip.txt
after #120 got merged

On Sat, May 16, 2015 at 6:06 PM, vdumoulin notifications@github.com wrote:

I'm debating adding an additional dependency (httmock) to mock HTTP
requests. It allows to speed up the tests as well as craft responses that
target specific cases in download helpers. Any thoughts?

—
Reply to this email directly or view it on GitHub
#118 (comment).

[bartvm]

Oh, and add them as an optional dependency in setup.py

[dwf]

IIRC there's some sort of "tests_require" thing in setup.py, no?

On Sat, May 16, 2015 at 6:08 PM, Bart van Merriënboer <
notifications@github.com> wrote:

Oh, and add them as an optional dependency in setup.py

—
Reply to this email directly or view it on GitHub
#118 (comment).

[bartvm]

https://github.com/mila-udem/blocks/blob/master/setup.py#L40-L44