Add subtree size #42
Merged
Add subtree size #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulesCornelissen
approved these changes
May 2, 2018
There was a problem hiding this comment.
Ziet er prima uit, alleen we gaan geen rekening houden met als een node zelf ook een grootte kan hebben anders dan 1? Lijkt me prima voor nu en voor de toekomst heb ik #43 aangemaakt.
Verder zie ik ook dat je subTreeSize als optional hebt defined, maar in je parser voeg je hier wel altijd een waarde aan toe dus zonder dat ik exact de implementatie ken van de parser lijkt me dit een implementatie detail.
RoanH
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@teards hierbij de sub-tree size berekeningen voor je algorithme.