Not able to identify RESQ nodes for non-root element

[abhinaba-ghosh]

RESQ version: 1.8.0

If root is used while fetching the resq nodes, it is able to identify the child elements. But, if non-root element is used, it is failing to identify the same. The attached screenshots will be more descriptive:

DOM:

Fetch Commands:

So, in first command it is not able to identify the child elements. Once the root is used, both the child products got identified.

[baruchvlz]

Hey @abhinaba-ghosh thanks for reporting this. Do you know if this happened in 1.7.1 as well? Also, could you provide a repo that I can clone and try this out.

[abhinaba-ghosh]

hi @baruchvlz , yes, it is happening with v1.7.1 too. I am seeing this is happening if a component is getting mounted asynchronously. But it is still wired.

[baruchvlz]

I'll take a look at this. Again, thanks for reporting.

[abhinaba-ghosh]

Hi @baruchvlz , sorry for pushing this in your busy schedule, but having an update about this issue would be pretty helpful.

[baruchvlz]

Hi @abhinaba-ghosh, I was trying to create a reproducible example for this, but was not able to.

I used this example:

import React from 'react';

import { resq$, resq$$ } from 'resq';

const Product = ({ text }) => (
  <div className="product">{text}</div>
);

const Container = () => (
  <div className="container">
    {
      ['Foo', 'Bar'].map((text, index) => <Product key={`${index}_${text}`} text={`${index}_${text}`} />)
    }
  </div>
)

function App() {

  React.useEffect(() => {
    window.$ = resq$;
    window.$$ = resq$$
  }, []);

  return (
    <>
      <Container />
    </>
  );
}

export default App;

As you can see in the image, i am able to retrieve both <Product /> components using the result from querySelector as well as the node from the result of using $('Container', root).

[abhinaba-ghosh]

Hi Thanks for re-confirming. I will try with the v1.9.0. If still exists, I will share the codebase.

[abhinaba-ghosh]

Hi @baruchvlz , some wired behavior after migrating to v1.9.0, byProps returning multiple nodes which is not the case with the earlier version. You can try out with this app.

[baruchvlz]

@abhinaba-ghosh Thanks for taking a look at v1.9.0. I'm not entirely sure why this is happening, but I tried out your last reported error with both sync and async approaches and could not reproduce.

Sync

Async

If you want to have a chat about this, feel free to reach out on Gitter.

[abhinaba-ghosh]

working well in the latest version.