Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow matching the rest of the path by "*path" parameter #15

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

prantlf
Copy link
Contributor

@prantlf prantlf commented Jul 9, 2017

This is the syntax used by Backbone.js, for example.

Suggested fix for the issue #14.

Add mocha and chai as dependencies to drive the unit tests.

Add unit tests for the basic routing functionality.

Exclude the unit tests from the NPM module package.

Exclude the NPM module dependencies from the git source control.
This is the syntax used by Backbone.js, for example.
@prantlf
Copy link
Contributor Author

prantlf commented Jul 9, 2017

If you accept my PR for adding unit tests (#13), I can create another PR with unit tests for this change (60cff1e).

@prantlf prantlf mentioned this pull request Jul 9, 2017
@prantlf
Copy link
Contributor Author

prantlf commented Jul 9, 2017

I updated this PR to include unit tests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant